to each his own.
I buy an almost top of the line, mac book pro, with 4-years of apple care. I tend to beat the hell out of it over the years. So I keep my previous version around as a backup for times when it is in for repair.
Then I buy a whole new machine after 5-6 years. By then I want a bigger... everything. Right now I am coming up on 4 years... and I am jonesing to get an M2 mac... but I am holding off.
and you can buy after market battery and hard drive.. they come with the funky screwdrivers needed to replace them.
I only do this for my ANCIENT devices.